Macro escaping: Escape macros in command lines as macros should
This wasn't a problem, due to a bug in nagios macro escaping, so lot of macros was escaped anyway, so macros wouldn't break the command line anyway.
When this bug is fixed, it's actually up to the requestor to request a command line escaped string, so lets do that too.
This only affects upcoming versions of nagios 4, but shouldn't break anything in versions prior to that.
I havn't tested this patch properly though, because I don't have a test environment for mod_gearman. But I can't see how this minor patch could actually not work. Take it or leave it.
But using command line macros without requesting proper escaping is going to be a problem.
sni
commented
11 years ago
Macro escaping: Escape macros in command lines as macros should
This wasn't a problem, due to a bug in nagios macro escaping, so lot of macros was escaped anyway, so macros wouldn't break the command line anyway.
When this bug is fixed, it's actually up to the requestor to request a command line escaped string, so lets do that too.
This only affects upcoming versions of nagios 4, but shouldn't break anything in versions prior to that.
I havn't tested this patch properly though, because I don't have a test environment for mod_gearman. But I can't see how this minor patch could actually not work. Take it or leave it.
But using command line macros without requesting proper escaping is going to be a problem.
Mostly due to this commit: http://sourceforge.net/p/nagios/nagioscore/ci/3e971bb699c144850a48662adfb4f181ff3a1597/ But also some commits around it...