search

snivilised / cobrass

🐲 Assistant for cli applications using cobra
https://pkg.go.dev/github.com/snivilised/cobrass
MIT License
1 stars 0 forks source link

rename skim to no-recurse #265

Closed plastikfan closed 7 months ago

plastikfan commented 7 months ago

The standard way to represent the opposite of a flag setting, is to define it as --no-foo, which mean skim should be defined as --no-recurse.

plastikfan commented 7 months ago

looks like I forgot to merge 1608957 and then deleted the branch thinking it was merged, so this needs to be re-implemented

plastikfan commented 7 months ago

Something strange is happeming with latest version of cobrass 0.4.3. pixa is using 0.4.3, but Skim appears still to be defined on the Cascade parameter set:

type CascadeParameterSet struct {
    Depth uint
    Skim  bool
}

... which makes no sense at all, since 0.4.3, contains this change already in commit 16089574218b7d4cb8247adaeba7af8c251329f2.

Following this link shows what the problem is. Git is not aware of this commit, so it looks like I made the mistake of pushing the commit without merging (probably a cockup in the rebase), so I'll have to reapply this commit. Looks like something went wrong with the release; the master branch does in fact contain required fix, but it wasnt in the 0.4.3 release, so no additional code is required for this. Just do the release again.