search

socialgenomics / discover-frontend

Ember frontend for Repositive discovery platform
0 stars 0 forks source link

[B] - DIS-266 & DIS-259 : loading twice the favourite counts and metrics not working #1039

Closed leojpod closed 6 years ago

leojpod commented 6 years ago

We don't need the FavCount mixin anymore since the dataset now receives the correct favourite count. This will fix DIS-259 and DIS-266 was caused by a stupid name conflict while trying to attempt to fix the favourite count.

leojpod commented 6 years ago

@DennisSchwartz in this state the stats are loaded from the dataset or request model and are not pulled from the favourite service directly by the Front-end. However, the always increasing favourite count reappeared which I guess is caused by the deleting event not being picked up by the domain hosting the dataset/requests, what do you reckon?

leojpod commented 6 years ago

Note: I've check the data returned by the calls to these info on prod and they do return the erroneous number of favourites

leojpod commented 6 years ago

This should not be merged until the problem mentioned above is resolved.

DennisSchwartz commented 6 years ago

@leojpod What are we doing with this now?

leojpod commented 6 years ago

merge it? 😶

leojpod commented 6 years ago

@DennisSchwartz it should solve the metrics issue while preserving the favcounts behaviour :)

DennisSchwartz commented 6 years ago

Go for it then :)