Closed Istar-Eldritch closed 7 years ago
The chrome tests are now passing.
The phantomjs tests, however, do not run. Because it's phantomjs, it decides to spit out cryptic error messages which do not point to the source of the problem 🤦♂️
After removing the query-parser module, the phantomjs tests run. So, I take it there is some syntax issue in the query parser?
@Istar-Eldritch Thoughts?
I'll dig a bit deeper into this and also check the latest query-parser pr.
Phantomjs Errors:
not ok 1 PhantomJS 2.1 - Global error: SyntaxError: Unexpected token 'const' at http://localhost:7357/assets/vendor.js, line 71810
---
Log: |
{ type: 'error',
text: 'SyntaxError: Unexpected token \'const\' at http://localhost:7357/assets/vendor.js, line 71810\n' }
...
not ok 2 PhantomJS 2.1 - Global error: Error: Could not find module ember-runtime required by: ember-testing/test/promise at http://localhost:7357/assets/test-support.js, line 58
---
Log: |
{ type: 'error',
text: 'Error: Could not find module ember-runtime required by: ember-testing/test/promise at http://localhost:7357/assets/test-support.js, line 58\n' }
...
not ok 3 PhantomJS 2.1 - Global error: ReferenceError: Can't find variable: define at http://localhost:7357/assets/main.js, line 5
---
Log: |
{ type: 'error',
text: 'ReferenceError: Can\'t find variable: define at http://localhost:7357/assets/main.js, line 5\n' }
...
not ok 4 PhantomJS 2.1 - Global error: ReferenceError: Can't find variable: define at http://localhost:7357/assets/tests.js, line 3
---
Log: |
{ type: 'error',
text: 'ReferenceError: Can\'t find variable: define at http://localhost:7357/assets/tests.js, line 3\n' }
...
not ok 5 PhantomJS 2.1 - Global error: ReferenceError: Can't find variable: EmberENV at http://localhost:7357/9295/tests/index.html?hidepassed, line 39
---
Log: |
{ type: 'error',
text: 'ReferenceError: Can\'t find variable: EmberENV at http://localhost:7357/9295/tests/index.html?hidepassed, line 39\n' }
After compiling down to es5 the problem was still persistent, so I modified testem following @SebastianPlace guidelites to use a headless chrome instead of PhantomJS.
Tests are passing and so far it looks like the system is working fine. Let me know if otherwise but I would say is ready to go.
Please remember to merge https://github.com/repositive/api.repositive.io/pull/238 at the same time you merge this one.
Update in the query parser to version 2.0.0
Blocked by https://github.com/repositive/api.repositive.io/pull/238