sofastack / sofa-jraft

A production-grade java implementation of RAFT consensus algorithm.
https://www.sofastack.tech/projects/sofa-jraft/
Apache License 2.0
3.56k stars 1.14k forks source link

Implementing Flexible Raft with NWR #1017

Closed 1294566108 closed 10 months ago

1294566108 commented 1 year ago

Motivation:

  1. 结合 Quorum NWR 模型实现 Flexible Raft
  2. 为Flexible Raft添加 resetfactor API,用于动态调节factor大小

Modification:

Implementing Flexible Raft with Quorum NWR Model Add ResetFactor API for flexible raft

Result:

Feature #1003 .

shihuili1218 commented 1 year ago

代码都提交了吗?

1294566108 commented 1 year ago

代码都提交了吗?

目前是最新的代码

killme2008 commented 11 months ago

Please let me know if it's ready, I want to do the code review. Thank u.

shihuili1218 commented 11 months ago

Please let me know if it's ready, I want to do the code review. Thank u.

we are nearing the end, please wait for our call. hah

shihuili1218 commented 11 months ago

@killme2008 look good for me. pls take the time to review again

killme2008 commented 10 months ago

@killme2008 look good for me. pls take the time to review again

Cool! Sorry, I don't have time these days, I will review it this weekend ASAP.

shihuili1218 commented 10 months ago

@killme2008 look good for me. pls take the time to review again

Cool! Sorry, I don't have time these days, I will review it this weekend ASAP.

Hi @killme2008 , I'd like to check on the progress of this PR's review. by the way, the deadline for OSPP is October 30th, and we need to ensure timely consolidation.[皱眉]

shihuili1218 commented 10 months ago

@1294566108 补充一下jepsen的验证结果呗。你可以在sofa-jraft-jepsen中创建pr,在这引用。后续可以关闭jepsen的pr

1294566108 commented 10 months ago

@1294566108补充一下jepsen的结果呗。你可以在sofa-jraft-jepsen中创建pr,在这引用。后续可以验证关闭jepsen的pr

已上传PR到sofa-jraft-jepsen仓库:https://github.com/sofastack/sofa-jraft-jepsen/pull/3

1294566108 commented 10 months ago

@fengjiachun Hi, the problem seems to have been resolved, could you please see if it is possible to merge

fengjiachun commented 10 months ago

LGTM