search

software-mansion / react-native-ide

https://ide.swmansion.com
Other
705 stars 21 forks source link

Use shared-prefs to avoid onboarding screen that blocks the UI in expo dev client #374

Closed kmagiera closed 2 weeks ago

kmagiera commented 2 weeks ago

This PR gets rid of the onboarding modal that pops up with expo-dev-client apps after launch.

Since the modal is blocking JS looper, it prevents the app from establishing devtools connection which may lead to timeouts and hence prevent "app ready" events. As a consequence, the IDE fails to recognize the app is properly launched.

Before, we've been using disableOnboarding flag passed as URL parameter when launching the app. However, it appears like it's never worked properly (see this fix here: https://github.com/expo/expo/pull/29697). For the time being we decided to use an alternative approach in which we write onboarding parameter into shared props that are used to store the information whether the popup should be displayed or not.

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-ide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2024 9:47pm