search

solettaproject / meta-soletta

Yocto layer for Soletta
MIT License
7 stars 12 forks source link

updates to soletta and soletta-dev-app #29

Closed mythi closed 8 years ago

mythi commented 8 years ago

This PR proposes a few changes to soletta and soletta-dev-app recipes. The summary of the changes include: drop dependency to host python3, make bitbake to build the node modules , and fix QA warnings

barbieri commented 8 years ago

+0 overall, I can't test it to give +1 atm, so let's wait @brunobottazzini to get to it.

My comments about npm do not need to be fixed now, but I'd like someone to take a look if that approach could fix the npm issues, this will become a recurrent topic for people doing node.js development with Yocto.

brunobottazzini commented 8 years ago

I have tested the patchset and it worked quite well. This approach to fix the npm problem is well done. I made a minor commentary the rest for me is +1

barbieri commented 8 years ago

then it's tested and clean, please merge.

In the other repos we're not using github's merge button, but doing rebase + push ourselves. You may pick that approach or use the mere PR button if you guys think it's the best option

mythi commented 8 years ago

@barbieri @brunobottazzini I can push the changes.