solettaproject / meta-soletta

Yocto layer for Soletta
MIT License
7 stars 12 forks source link

soletta: Add microhttpd and systemd as dependency #48

Closed brunobottazzini closed 8 years ago

brunobottazzini commented 8 years ago

Signed-off-by: Bruno Bottazzini bruno.bottazzini@intel.com

brunobottazzini commented 8 years ago

@mythi and @barbieri, could you review this patch please ?

brunobottazzini commented 8 years ago

Added in the patch minimum version for libmicrohttpd.

mythi commented 8 years ago

(>= 0.9.43) does not seem to have any effect because the build nicely succeeds with .34

kad commented 8 years ago

@mythi what "bitbake-layers show-recipes" shows about libmicrohttpd ? both versions available or only one ?

mythi commented 8 years ago

@brunobottazzini can you rebase this (it gives a merge conflict)

@kad just .34 recipe is available for this PR (.43 is not whitelisted in ostro.conf yet)

brunobottazzini commented 8 years ago

@mythi, rebased :)

mythi commented 8 years ago

@brunobottazzini thanks! I'll wait for the CI results and then push if ok

kad commented 8 years ago

bug in bitbake then? it shouldn't be ignoring versioned requirement.

mythi commented 8 years ago

@kad the version check operator seems to be documented in RCONFLICTS. Perhaps it's only available for run-time conflict checking.

kad commented 8 years ago

@rpurdie, @rossburton : is it so that versioned requirements do not work for DEPENDS field ?

rossburton commented 8 years ago

On 21 March 2016 at 10:03, Alexander D. Kanevskiy notifications@github.com wrote:

@rpurdie https://github.com/rpurdie, @rossburton https://github.com/rossburton : is it so that versioned requirements do not work for DEPENDS field ?

Correct.

Ross

mythi commented 8 years ago

@brunobottazzini let's drop the (>= 0.9.43) still

kad commented 8 years ago

@rossburton is that intentional (due to some design implementation) or just a bug ? For me it sounds like a bug, if it's correctly parsed but not taken into effect.

rpurdie commented 8 years ago

We have considered adding versioned DEPENDS, I believe there was once a feature request open for this. We did go as far as ensuring the syntax was accepted by the parser and code so that we could markup recipes. Right now its simply not acted upon though. I can't find that feature request now...

brunobottazzini commented 8 years ago

@mythi, I just dropped the (>= 0.9.43). I will wait the CI check and merge this patch

kad commented 8 years ago

@rpurdie would you consider actually taking it into use ? Because if people are setting DEPENDS to some version, it usually means that they for some reason need some minimal version to properly functioning.

mythi commented 8 years ago

@brunobottazzini thanks! I've pushed it. The test build used to be OK.