search

solettaproject / meta-soletta

Yocto layer for Soletta
MIT License
7 stars 12 forks source link

soletta: Add Node.js bindings to soletta package #60

Closed nagineni closed 8 years ago

nagineni commented 8 years ago

This patch exports the needed variables to build Node.js bindings and add them to the soletta package.

Signed-off-by: Sudarsana Nagineni sudarsana.nagineni@intel.com

nagineni commented 8 years ago

@mythi @brunobottazzini Could you please have a look?

brunobottazzini commented 8 years ago

Checking the CI failure.

Do compile has failed just for intel-corei7-64. The rest has built it successfully

07:31:24 | tools/build/Makefile.targets:203: recipe for target 'bindings-nodejs' failed
07:31:24 | make: *** [bindings-nodejs] Error 1
07:31:24 | ERROR: oe_runmake failed

It is worth checking this out before merging this patch.

nagineni commented 8 years ago

@brunobottazzini Thanks. It's failing with the following linking error.

07:31:24 |   SOLINK_MODULE(target) Release/obj.target/soletta.node
07:31:24 | /var/lib/jenkins/ostro-worker-12-slot-1-5OzDI/ostro-os/build/tmp-glibc/sysroots/x86_64-linux/usr/bin/x86_64-ostro-linux/../../libexec/x86_64-ostro-linux/gcc/x86_64-ostro-linux/5.3.0/ld:
 Release/obj.target/soletta/bindings/nodejs/generated/main.o: relocation R_X86_64_PC32 against symbol `_ZN3Nan3NewIN2v86StringEPKcEENS_3imp7FactoryIT_E8return_tET0_' can not be used when making a shared object; recompile with -fPIC
07:31:24 | /var/lib/jenkins/ostro-worker-12-slot-1-5OzDI/ostro-os/build/tmp-glibc/sysroots/x86_64-linux/usr/bin/x86_64-ostro-linux/../../libexec/x86_64-ostro-linux/gcc/x86_64-ostro-linux/5.3.0/ld: final link failed: Bad value
07:31:24 | collect2: error: ld returned 1 exit status
07:31:24 | soletta.target.mk:174: recipe for target 'Release/obj.target/soletta.node' failed

I will look into it.

nagineni commented 8 years ago

I will submit a new PR.