solettaproject / meta-soletta

Yocto layer for Soletta
MIT License
7 stars 12 forks source link

Replace npm installation to use the fetcher from Yocto #72

Closed brunobottazzini closed 8 years ago

brunobottazzini commented 8 years ago

This move the source downloads to the do_fetch phase instead of do_compile.

Also, the build system could cache the sources, reducing the number of places where the download could go wrong.

Signed-off-by: Bruno Bottazzini bruno.bottazzini@intel.com

brunobottazzini commented 8 years ago

Details from npm yocto fetcher: http://git.openembedded.org/bitbake/tree/lib/bb/fetch2/npm.py

This patch was suggested by @ipuustin, could you review it? Thanks!

ipuustin commented 8 years ago

Did you check that the patch added in https://github.com/ostroproject/meta-ostro/pull/65 still applies after the change?

brunobottazzini commented 8 years ago

@ipuustin, ostroproject/meta-ostro#65 still applies...

brunobottazzini commented 8 years ago

V2 with bower.bb created

mythi commented 8 years ago

@brunobottazzini @ipuustin looks nice, thanks!

brunobottazzini commented 8 years ago

I'm closing this PR and Applying https://github.com/solettaproject/meta-soletta/pull/76 that I am more confident to be running things better and in a closer future we can reopen and discuss this patch :)