Add some more tests - Githubissues

source-academy / stories-backend

Backend of Source Academy extension for Stories support.

0 stars 0 forks source link

Open RichDom2185 opened 1 year ago

RichDom2185 commented 1 year ago

Adds some relatively-straightforward tests in some places.

RichDom2185 commented 1 year ago

@YaleChen299 should AnyOf pass or fail in the trivial case with 0 permissions?

RichDom2185 commented 1 year ago

My opinion is:

"All of N" → "pass if you fulfil all N requirements" → all of nothing means all requirements out of 0 will always be fulfilled → always pass
"Any of N" → "pass if you have at least one out of N" → you can't have at least one permission out of 0 (because there are no permissions in the first place for you to have) → always fail

But this is up for discussion, depending on what makes sense for us.