search

source-academy / stories-backend

Backend of Source Academy extension for Stories support.
0 stars 0 forks source link

Make users provider agnostic #58

Closed RichDom2185 closed 1 year ago

RichDom2185 commented 1 year ago

Part of #18.

We include a schema migration, but not a data migration, as it is not necessary at this stage of the codebase (not deployed).

RichDom2185 commented 1 year ago

@YaleChen299 I chose for it to be done this way so that we can keep a separate notion of which login providers are supported from which login providers are enabled for a particular deployment (can easily be checked using a config flag in the validation method).

What do you think?

RichDom2185 commented 1 year ago

Waiting to fix error: User creation in DB somehow calls the .String() method of the enum, thus violating the integer type.

github-actions[bot] commented 1 year ago

Coverage Status

coverage: 83.0% (+0.6%) from 82.353% when pulling 7cdfa56f78d4a91ee80ef81320cf42b763a80dbe on make-users-provider-agnostic into 4e87ba6a56939fcac758c68917afe0265235afce on main.

YaleChen299 commented 1 year ago

@YaleChen299 I chose for it to be done this way so that we can keep a separate notion of which login providers are supported from which login providers are enabled for a particular deployment (can easily be checked using a config flag in the validation method).

What do you think?

Okay! I think this looks good.