search

source-academy / stories-backend

Backend of Source Academy extension for Stories support.
0 stars 0 forks source link

Refactor tests #82

Closed YaleChen299 closed 1 year ago

YaleChen299 commented 1 year ago

allow make test to specify a path rename variables

github-actions[bot] commented 1 year ago

Coverage Status

coverage: 48.571%. remained the same when pulling 9e076aaff6459cd1ee7bceea1828f615a8967491 on test-refactor into 820f3b4e78325472af2b3083c321bfe8c7f8f6bf on main.

YaleChen299 commented 1 year ago

Minor nitpick: since the Makefile is generic (not just for tests), would it make more sense if the path variable is called testpath?

But either way, this is very minor and not really used now, so LGTM. Thanks for the refactor!

Alright, we can change when more features are added to the makefile.