sqs
commented
7 years ago Thanks! This is awesome. If anyone else following this repo wants to code review, go ahead. Otherwise I will take a look in the next few days. On Thu, Sep 8, 2016 at 01:38 Mihael Dimec notifications@github.com wrote:
Hi
In last years I have fixed some bugs and added some new features to our fork, but now when we are abandoning the project in favour of small more flexible custom webkit bindings. This code will also not work with Go 1.6 (see: https://golang.org/doc/go1.6#cgo)
I know you haven’t also updated the project for long time, but you are welcome to take any feature or bug fix from our branch you want. For completes. Maybe if somebody else will want to continue the work.
best
Miha
You can view, comment on, or merge this pull request online at:
https://github.com/sourcegraph/go-webkit2/pull/30 Commit Summary
- changed inports
- changed glib Connect api to new version of gotk3
- tests
- Merge remote-tracking branch 'sourcegraph/master'
- GetSnepshot(): Protect callback from GC
- go-webkit2: GetSnapshot: more optins with GetSnapshotCustum
- small changes
- go fmt
- spelling error
- spelling 2
- Added remote webkit inspector.
- go fmt
- add SetExtensionsDir to go-webkit2
- webkit2: fix WebKitWebContext
- Merge pull request #1 from visionect/develop
- cookie local storage gotk3/go-webkit2
- Small fix for webview.go
- compilable with go 1.3.1 compiler
- better load fail handling
- conflict CString() free
- mulltiple processes can't share the same cache location
- conflicts
- go-webkit2 conflicts
- go-webkit2 conflicts2
- color order fix
- Issue #331 not finished yet. Timer works. JS api is prepared. Connect together and add modification option to admin.
- webkit image debug messages!
- webkit: optimize cairo endian dependent to RGBA image pixels flip.
379
- Remove debug messages.
- Merge remote-tracking branch 'origin/develop'
- Merge remote-tracking branch 'sourcegraph/master' into sg_pull_req_1
- fix paths back to sourcegraph
File Changes
- M README.md https://github.com/sourcegraph/go-webkit2/pull/30/files#diff-0 (4)
- M cmd/webkit-eval-js/evaljs.go https://github.com/sourcegraph/go-webkit2/pull/30/files#diff-1 (3)
- A webkit2/cairo_endianes.c https://github.com/sourcegraph/go-webkit2/pull/30/files#diff-2 (144)
- A webkit2/cairo_endianes.go https://github.com/sourcegraph/go-webkit2/pull/30/files#diff-3 (15)
- A webkit2/cairo_endianes.h https://github.com/sourcegraph/go-webkit2/pull/30/files#diff-4 (5)
- A webkit2/cairo_endianes_test.go https://github.com/sourcegraph/go-webkit2/pull/30/files#diff-5 (48)
- A webkit2/cookiemanager.go https://github.com/sourcegraph/go-webkit2/pull/30/files#diff-6 (85)
- M webkit2/gasyncreadycallback.go https://github.com/sourcegraph/go-webkit2/pull/30/files#diff-7 (22)
- M webkit2/settings.go https://github.com/sourcegraph/go-webkit2/pull/30/files#diff-8 (23)
- M webkit2/webcontext.go https://github.com/sourcegraph/go-webkit2/pull/30/files#diff-9 (47)
- M webkit2/webview.go https://github.com/sourcegraph/go-webkit2/pull/30/files#diff-10 (127)
- M webkit2/webview_test.go https://github.com/sourcegraph/go-webkit2/pull/30/files#diff-11 (18)
Patch Links:
- https://github.com/sourcegraph/go-webkit2/pull/30.patch
- https://github.com/sourcegraph/go-webkit2/pull/30.diff
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/sourcegraph/go-webkit2/pull/30, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAHuKdmVpklf5oTkyI2MheiRZVw0x8Cks5qn8lmgaJpZM4J3vm_ .
Hi
In last years I have fixed some bugs and added some new features to our fork, but now we are abandoning the project in favour of small more flexible custom webkit bindings. This code will also not work with Go 1.6 (see: https://golang.org/doc/go1.6#cgo and https://github.com/mattn/go-pointer)
I know you haven’t also updated the project for long time, but you are welcome to take any feature or bug fix from our branch you want. For completes. Maybe if somebody else will wants to continue the work.
best
Miha