search

sourcegraph / go-webkit2

WebKit API bindings (WebKitGTK+ v2) for Go
https://sourcegraph.com/github.com/sourcegraph/go-webkit2
Other
313 stars 61 forks source link

libwebkit2gtk-4.0 support? #31

Closed paultag closed 7 years ago

paultag commented 7 years ago

I was just playing around with pulling down HTML and rendering it, and I came across this library - thanks for all your hard work, looks really great!

It looks like libwebkit2gtk-3.0 was removed from Debian testing and unstable, which means the next Ubuntus will have that package missing as well.

I'm super happy to test any changes -- unfortunately, I don't know much GTK otherwise I'd have set in a PR. Thanks for putting up with a basically unhelpful bug.

I'll glance through the GTK changelog and see how bad it's going to be, but I seem to recall some angry people on the internet saying it was basically totally API incompatible. Woof.

paultag commented 7 years ago

After asking around, this isn't actually the famed GTK4, so it's just that webkit2 has a new bump. I'll check into it.

paultag commented 7 years ago 
-// #cgo pkg-config: webkit2gtk-3.0
+// #cgo pkg-config: webkit2gtk-4.0

Actually appears to compile. I'll see if it's happy

paultag commented 7 years ago

Yep, that plus https://github.com/sourcegraph/go-webkit2/pull/32 allowed me to build the example!

sqs commented 7 years ago

Merged sourcegraph/go-webkit2#32.

@paultag can you please submit a PR with that diff to use 4.0 if that is necessary? Thanks!

paultag commented 7 years ago

Will do! I'll also send another PR for the user data changes as well.

Thanks!

On Oct 3, 2016 10:07 AM, "Quinn Slack" notifications@github.com wrote:

Merged sourcegraph/go-webkit2#32 https://github.com/sourcegraph/go-webkit2/pull/32.

@paultag https://github.com/paultag can you please submit a PR with that diff to use 4.0 if that is necessary? Thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/sourcegraph/go-webkit2/issues/31#issuecomment-251114930, or mute the thread https://github.com/notifications/unsubscribe-auth/AAIFX9TuqlnUtm8bmQQeYX6UUy0CrGv2ks5qwQwjgaJpZM4KMG8j .

paultag commented 7 years ago

Closed in #34