search

sourcegraph / go-webkit2

WebKit API bindings (WebKitGTK+ v2) for Go
https://sourcegraph.com/github.com/sourcegraph/go-webkit2
Other
313 stars 61 forks source link

Adding basic rgba snapshot support #5

Closed bryansum closed 10 years ago

sqs commented 10 years ago

Looks great. How about:

  1. adding a golint-compliant docstring to GetSnapshot similar to the other docstrings, with a link to the WebKitGTK+ v2 API functions it calls
  2. adding a check in TestWebView_GetSnapshot for some minimum image dimensions or minimum byte size, just so we know it's returning something

LGTMerge with those things done (and if the 2nd one is not possible, that's fine).

sqs commented 10 years ago

Awesome. Thanks!