search

souvik-ghosh / react-native-create-thumbnail

iOS/Android thumbnail generator with support for both local and remote videos
MIT License
246 stars 105 forks source link

Fix for Android SDK 33 #100

Closed humanzai closed 8 months ago

humanzai commented 1 year ago

Wrapped retriever.release() in try catch for Android SDK 33

Zurarose commented 11 months ago

its working. Can somebody accept this?

samiullah452 commented 11 months ago

Should'nt it be IOException rather than Exception so that we catch only the specific exception rather than the general class of Exception

Zurarose commented 11 months ago

Should'nt it be IOException rather than Exception so that we catch only the specific exception rather than the general class of Exception

Fully tested it yesterday. It is okay

Zurarose commented 11 months ago

Should'nt it be IOException rather than Exception so that we catch only the specific exception rather than the general class of Exception

Fully tested it yesterday. It is okay

If somebody need this, for now, you can use patch-package

1) yarn add patch-package 2) add to your package.json scripts

"postinstall": "yarn patch-package"

3) apply changes above to your node_modules/react-native-create-thumbnail/....CreateThumbnailModule.java 4) npx patch-package react-native-create-thumbnail

souvik-ghosh commented 8 months ago

This change was already available as a pre-release in version 2.0.0-rc*. Please check existing issues before reporting. The linked issues were also pinned in the issues tab. Version 2.0.0 was released yesterday.