search

souvik-ghosh / react-native-create-thumbnail

iOS/Android thumbnail generator with support for both local and remote videos
MIT License
246 stars 105 forks source link

fix: build failures for android SDK 33 #102

Closed adityamohta closed 8 months ago

adityamohta commented 11 months ago

Issue

/.../app/node_modules/react-native-create-thumbnail/android/src/main/java/com/createthumbnail/CreateThumbnailModule.java:192: error: unreported exception IOException; must be caught or declared to be thrown
        retriever.release();
                         ^
Note: /.../app/node_modules/react-native-create-thumbnail/android/src/main/java/com/createthumbnail/CreateThumbnailModule.java uses or overrides a deprecated API.
adityamohta commented 11 months ago

Thank you for the amazing package. I use this in one of my very important projects so I had to installed a forked version for now. However, it would be fantastic to get this merged so I could revert back to using the Orginal.

PS: I noticed there is another open PR: https://github.com/souvik-ghosh/react-native-create-thumbnail/pull/100 however, the exception seems too wide for the actual problem.

souvik-ghosh commented 8 months ago

This change was already available as a pre-release in version 2.0.0-rc*. Please check existing issues before reporting. The linked issues were also pinned in the issues tab. Version 2.0.0 was released yesterday.

adityamohta commented 8 months ago

This change was already available as a pre-release in version 2.0.0-rc*. Please check existing issues before reporting. The linked issues were also pinned in the issues tab. Version 2.0.0 was released yesterday.

Ah, my bad @souvik-ghosh ! Thanks for highlighting it. 🙂