Closed Bayramito closed 3 years ago
Hello,
I am also facing the same issue only on Android build. IOS build is working fine.
Environnement: react-native: ^0.63.3, react-native-create-thumbnail:^1.2.1
Would anyone have a suggestion on how this issue could be fixed for Android ?
Any help would be appreciated :)
Thank you very much
Hello,
Me too having the same problem
Env: "react-native": "0.61.5", react-native-create-thumbnail:^1.2.1
any suggestion for workaround?
Appears to be a dependency problem with commons-io
In ~/react-native-create-thumbnail/android/build.gradle
change
implementation 'commons-io:commons-io:+'
to
implementation 'commons-io:commons-io:2.8.0'
In
~/react-native-create-thumbnail/android/build.gradle
changeimplementation 'commons-io:commons-io:+'
toimplementation 'commons-io:commons-io:2.8.0'
2.8 didn't work for me, I had to use 2.7... I have an open PR https://github.com/souvik-ghosh/react-native-create-thumbnail/pull/30
Thanks for the quick work @boldwade - hopefully maintainers can get that reviewed/merged soon. Preventing all Android builds on CI servers without that.
In
~/react-native-create-thumbnail/android/build.gradle
changeimplementation 'commons-io:commons-io:+'
toimplementation 'commons-io:commons-io:2.8.0'
worked for me! Thanks @geek-ibrar
In
~/react-native-create-thumbnail/android/build.gradle
changeimplementation 'commons-io:commons-io:+'
toimplementation 'commons-io:commons-io:2.8.0'
This also worked for me @geek-ibrar
You're right @geek-ibrar , not sure why my initial 2.8 draft didn't work... but yep it does actually.
In
~/react-native-create-thumbnail/android/build.gradle
changeimplementation 'commons-io:commons-io:+'
toimplementation 'commons-io:commons-io:2.8.0'
thanks bro. it's worked
@jjhampton we have done this workaround for CI CD.
// RNCreateThumbLibFix.js
var fs = require('fs');
(function () {
const inputFile = `./node_modules/react-native-create-thumbnail/android/build.gradle`;
fs.readFile(inputFile, 'utf8', function (err, data) {
if (err) {
return console.log(err);
}
var currentData = data;
var newData =
!!currentData &&
currentData.replace(
'commons-io:commons-io:+',
'commons-io:commons-io:2.8.0',
);
fs.writeFile(inputFile, newData, 'utf8', function (err) {
if (err) return console.log(err);
});
});
})();
// package.json
"version": "1.0.1",
"private": true,
"scripts": {
"android": "react-native run-android",
"ios": "react-native run-ios",
"start": "react-native start",
"update:RNCreateThumbLibFix": "node RNCreateThumbLibFix",
"postinstall": "npm run update:RNCreateThumbLibFix;"
},
In
~/react-native-create-thumbnail/android/build.gradle
changeimplementation 'commons-io:commons-io:+'
toimplementation 'commons-io:commons-io:2.8.0'
Thanks its worked
Thanks, guys! v1.2.2 has been released with the fix.
I get this error when i try to build my app.
******\node_modules\react-native-create-thumbnail\android\src\main\java\com\createthumbnail\CreateThumbnailModule.java:27: error: package org.apache.commons.io.comparator does not exist import org.apache.commons.io.comparator.LastModifiedFileComparator; ^ ****\node_modules\react-native-create-thumbnail\android\src\main\java\com\createthumbnail\CreateThumbnailModule.java:94: error: cannot find symbol Arrays.sort(files, LastModifiedFileComparator.LASTMODIFIED_COMPARATOR); ^ symbol: variable LastModifiedFileComparator location: class CreateThumbnailModule Note: ****\node_modules\react-native-create-thumbnail\android\src\main\java\com\createthumbnail\CreateThumbnailModule.java uses unchecked or unsafe operations. Note: Recompile with -Xlint:unchecked for details. 2 errors
"react-native": "^0.62.2", "react-native-create-thumbnail": "^1.2.1"