search

spdx / spdx-online-tools

Source for the website providing online SPDX tools
https://tools.spdx.org
Apache License 2.0
60 stars 57 forks source link

Created Folder structure for tests for app #497

Open BassCoder2808 opened 1 year ago

BassCoder2808 commented 1 year ago
BassCoder2808 commented 1 year ago

Hi @rtgdk can you please check this once and let me know if I am doing it correctly, like we need to do something similar for the api folder so, if this one looks good, I will follow the similar structure for it as well

BassCoder2808 commented 1 year ago

Please provide the screenshot and the command used to run all test cases. Show the output as successfull

image Hi @rtgdk I think all the tests are working like I tried this on both the main and Test-Files branch and the tests which are failing are common like they are the firefox ones I think it cannot find the relevant webdriver on my local wsl setup So once I like do the same for the other modules can you please run my branch locally before merging it

rtgdk commented 1 year ago

Overall changes LGTM. I hope there is no code leakage in this - very difficult to review for that. I would have loved to have a common setup/teardown for all tests and having all tests run without failure/skipping but I guess these will need some rethinking on how to run test cases run - currently a lot of duplicate code exists .

@BassCoder2808 Can you please list down the test cases not working on your machine? This will make the dataset for tests affected by selenium/firefox usecases and provide us a start to move these to unit based framework.

There are already some issues opened for fixing these testcases. Let's try to fix some of them.

Holding to merge this diff for sometime - until I run tests on this branch locally.