Added the GUI changes - Githubissues

spdx / spdx-online-tools

Source for the website providing online SPDX tools

https://tools.spdx.org

Apache License 2.0

60 stars 57 forks source link

Added the GUI changes #500

Closed BassCoder2808 closed 1 year ago

BassCoder2808 commented 1 year ago

Added the GUI changes for the license and exceptions as discussed in the doc shared by @jlovejoy @rtgdk can you review this once and let me know if anything else needs to be changed in this

rtgdk commented 1 year ago

@BassCoder2808 Please add the screenshots for this change. @jlovejoy Can you please review the screenshot and confirm the changes you wanted?

rtgdk commented 1 year ago

Posting the screenshot from my local testing.

@BassCoder2808 I think you covered all the points mentioned by @jlovejoy on the doc from the UI text change perspective. Merging this now as it LGTM.

jlovejoy commented 1 year ago

not sure what the above comment was referencing, but looking at the screenshot, I'm assuming the "is this a license exception" defaults to no, and the drop-down allows one to choose yes - if so, that seems good!

rtgdk commented 1 year ago

@jlovejoy Yes that is true.