specklesystems / speckle-sharp

.NET SDK, Schema and Connectors: Revit, Rhino, Grasshopper, Dynamo, ETABS, AutoCAD, Civil3D & more.
https://speckle.systems
Apache License 2.0
372 stars 170 forks source link

Tekla objects missing from CanConvertToNative in Revit Connector #1757

Open eestrado opened 1 year ago

eestrado commented 1 year ago

Prerequisites

Describe the bug

CanConvertToNative() method in the Revit Connector is missing the Tekla objects. When you receive these objects are not converted even when Receive as Direct Mesh option is selected. Only beams are converted.

To Reproduce

Receive a stream in Tekla that has Tekla objects in it with Receive as Direct Mesh enabled.

Expected behavior

All defined objects from Tekla should be converted as Direct Mesh

Proposed Solution (if any)

These 3 lines should be added to the CanConvertToNative method:

BE.TeklaStructures.TeklaContourPlate _ => true,
          BE.TeklaStructures.Bolts _ => true,
          BE.TeklaStructures.Welds _ => true,
AlanRynne commented 1 year ago

Hi @eestrado! Thanks for bringing this up! It's a legit bug although, I think we're going to try and come up with a better solution than to have to manually add the objects to the CanConvert method on the long term.

I'll have a quick chat with the team about possibly shipping the fix you suggested while we find a more scalable solution.

Our 2.9 release is about to go out and this may be a harmless addition ;) No promises though! 🤞🏼

We'll keep you posted on this