specklesystems / speckle-sharp

.NET SDK, Schema and Connectors: Revit, Rhino, Grasshopper, Dynamo, ETABS, AutoCAD, Civil3D & more.
https://speckle.systems
Apache License 2.0
372 stars 171 forks source link

Our logging effort clashes with RhinoCompute #2258

Closed gjedlicska closed 1 year ago

gjedlicska commented 1 year ago

Rhino compute uses Serilog too as their logging platform.

If a user has the Rhino / Grasshopper Connector installed and runs Rhino Compute on that machine, our current logs are merged with their logs resulting in:

The fix for this is to not use the Serilog global static logger, but to store our own instantiated logger in our own static property. This is mostly a brainless refactor, but it has to happen across all connectors for consistency.

gjedlicska commented 1 year ago

hey @JR-Morgan can i drop this ball on you? The core part is done in #2313, we need to make sure connectors use the SpeckleLog.Logger global static instance instead of the Serilog.Log convenience methods, to avoid hijacking other plugin devs logs.

Once we're done with the refactor in sharp and manager, we need to remove this line

JR-Morgan commented 1 year ago

Cool! on it

teocomi commented 1 year ago

Closing as temporarily fixed. Related to https://github.com/specklesystems/speckle-sharp/issues/2477