search

specklesystems / speckle-sharp

.NET SDK, Schema and Connectors: Revit, Rhino, Grasshopper, Dynamo, ETABS, AutoCAD, Civil3D & more.
https://speckle.systems
Apache License 2.0
370 stars 170 forks source link

Revit Connector: doesn't apply ParameterUpdater using applicationId #3379

Open samberger opened 4 months ago

samberger commented 4 months ago

It's about the Revit Connector, when importing back a ParameterUpdater object.

"//try to get element using UniqueId" is using the elementId again, but should this be the applicationId which would be used as uniqueId for Doc.GetElement()? As far as I understood, it's also this Revit's uniqueId, which is saved as Speckle's applicationId when uploading.

https://github.com/specklesystems/speckle-sharp/blob/b67e46c0dc3eee8572f4cf9c9cdef339949f536b/Objects/Converters/ConverterRevit/ConverterRevitShared/PartialClasses/UpdateParameter.cs#L30C45-L30C54

samberger commented 4 months ago

When I adapt the ParameterUpdater properties to the given code, and use the applicationId also as elementId, it works (although it's apparently not the correct/original elementId).

grafik