CNX-9439 interacting with structural gh models in the viewer

specklesystems / speckle-sharp

.NET SDK, Schema and Connectors: Revit, Rhino, Grasshopper, Dynamo, ETABS, AutoCAD, Civil3D & more.

https://speckle.systems

Apache License 2.0

363 stars 167 forks source link

CNX-9439 interacting with structural gh models in the viewer #3451

Closed JR-Morgan closed 3 months ago

JR-Morgan commented 3 months ago

Added new behaviour for the following types

Wall, RevitWall,
Beam, RevitBeam,
Column, RevitColumn,
Duct, RevitDuct,
Brace, RevitBrace
Beam,
Element1D

Important to note, I have intentionally NOT changed the signatures of any Schema Info constructors, only their implementation (to call the main mega constructor)

when using a parameterised constructor, if no displayValues are passed in, the class will fallback to using the baseCurve/baseLine instead

JR-Morgan commented 3 months ago

Tested creating a GH document with schema nodes for the above types. Upgrading 2.19 -> this PR doesn't break any nodes because the schema info constructors have not changed signature

JR-Morgan commented 3 months ago

Once this is merged, I would quite like to make a 2.20-wip for community to try out.