feat(Archicad): Update connector icon on mac - Githubissues

specklesystems / speckle-sharp

.NET SDK, Schema and Connectors: Revit, Rhino, Grasshopper, Dynamo, ETABS, AutoCAD, Civil3D & more.

https://speckle.systems

Apache License 2.0

354 stars 166 forks source link

feat(Archicad): Update connector icon on mac #3474

Closed jozseflkiss closed 1 month ago

jozseflkiss commented 1 month ago

Description & motivation

Fixes: #3269

Changes:

Wireframe svg Speckle icon added for Archicad add-on on Mac
ConnectorArchicad has been packed as bundle on Mac, in order to have icon for the app
- plist added
- Speckle icon added
Create app bundles action added to build connector GitHub actions

To-do before merge:

There are changes in the speckle-sharp-ci-tools repo, which I could not add, however should be merged before this PR. Until that this PR will fail
Need to call uninstall action before installing a new version of the connector in Speckle Manager to clean up previous files

Screenshots:

Checklist:

[x] My pull request follows the guidelines in the Contributing guide?
[x] My pull request does not duplicate any other open Pull Requests for the same update/change?
[x] My commits are related to the pull request and do not amend unrelated code or documentation.
[x] My code follows a similar style to existing code.
[x] I have added appropriate tests.
[ ] I have updated or added relevant documentation.

AlanRynne commented 1 month ago

Changed base branch so we can run the changes internally (including the installer part, which external PRs don't run)