search

specklesystems / speckle-sharp

.NET SDK, Schema and Connectors: Revit, Rhino, Grasshopper, Dynamo, ETABS, AutoCAD, Civil3D & more.
https://speckle.systems
Apache License 2.0
354 stars 166 forks source link

Revit file sharing #3476

Closed adamhathcock closed 1 month ago

adamhathcock commented 1 month ago

Overrides https://github.com/specklesystems/speckle-sharp/pull/3468

Uses info from https://github.com/dotnet/sdk/issues/2511

Basically, shared projects are deprecated and only made because of UWP. Using the new build system features makes us more future proof

adamhathcock commented 1 month ago

Got some questions about this before we merge. My understanding is that NoTarget SDK projects are intended for projects that have no code but do have project dependencies (i.e. building it results in no DLL being built, just it's dependencies being copied) The way we're doing this is somewhat opposite to that 🤔

You're right....the shared csprojs could be deleted and we wouldn't need to exclude the OBJ folder as it wouldn't exist. The shared csproj is just for viewing in the SLN

files are directly added to each csproj via the compile include

adamhathcock commented 1 month ago

went through this again with @AlanRynne in some detail and actually gives a slightly worse DX even though shprojs aren't supported going forward. Taking this on the chin for now.