specklesystems / speckle-sharp

.NET SDK, Schema and Connectors: Revit, Rhino, Grasshopper, Dynamo, ETABS, AutoCAD, Civil3D & more.
https://speckle.systems
Apache License 2.0
354 stars 166 forks source link

fetching branchName for FE2 URLs #3487

Closed KatKatKateryna closed 1 month ago

KatKatKateryna commented 1 month ago

This solves the Grasshopper Outdated Receive Component notification issue in FE2, because the branch.name of the commit created on the server should correspond to the StreamWrapper subscription. And so far it was "hacked" to store the branch id as a BranchName for FE2 URLs.

While this is a "proper" way to set the branchName, it might affect other methods using StreamWrapper constructor. Send/Receive was tested and works fine. But if this is too risky, we can switch to another hack checking for the branch.id here instead: image

jsdbroughton commented 1 month ago

This still has the issue of branch 101+ won't work (@jsdbroughton I know you love this limitation), but I think we can live with this?

fixing the branch limits would be out of scope for this anyways..