search

specklesystems / speckle-sharp

.NET SDK, Schema and Connectors: Revit, Rhino, Grasshopper, Dynamo, ETABS, AutoCAD, Civil3D & more.
https://speckle.systems
Apache License 2.0
351 stars 162 forks source link

Added support for IReadOnlyList deserialization #3520

Closed JR-Morgan closed 3 weeks ago

JR-Morgan commented 3 weeks ago

https://github.com/specklesystems/speckle-sharp/pull/3451 introduced an issue where we were successfully serializing, but not successfully deserializing IReadOnlyList properties.

This somehow got through my round of testing.... my bad! but thanks @gjedlicska for spotting this while 2.20 is still in wip! 🙌

In This PR

  1. Added support in our deserializer for IList and IReadOnlyList typed properties
  2. Added a unit test for said support
  3. Added a test in Objects.Tests to test that object model properties are one of the types supported by both our serializer and Deserializer (hard coded right now). Hopefully this will help ensure we never introduce this type of issue again.