Dui3 124 receiving curves arcs ellipses nurbs curves

specklesystems / speckle-sharp

.NET SDK, Schema and Connectors: Revit, Rhino, Grasshopper, Dynamo, ETABS, AutoCAD, Civil3D & more.

https://speckle.systems

Apache License 2.0

351 stars 162 forks source link

Dui3 124 receiving curves arcs ellipses nurbs curves #3521

Closed KatKatKateryna closed 1 week ago

KatKatKateryna commented 3 weeks ago

Description & motivation

Changes:

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

[ ] My pull request follows the guidelines in the Contributing guide?
[ ] My pull request does not duplicate any other open Pull Requests for the same update/change?
[ ] My commits are related to the pull request and do not amend unrelated code or documentation.
[ ] My code follows a similar style to existing code.
[ ] I have added appropriate tests.
[ ] I have updated or added relevant documentation.

References

clairekuang commented 1 week ago

Just a general comment: it would be good to align the ArcGIS converter project to have the same structure as the other DUI3 connectors: [Connector] > ToSpeckle / ToHost > [Speckle namespace, eg Geometry] / Raw > converter. Currently ArcGIS is organized like ArcGIS > [ArcGIS type, eg Feature] > converter (for to host, to speckle, and raw)

KatKatKateryna commented 1 week ago

@AlanRynne only 1 draft PR is waiting for these changes, will only affect several files. The other PRs are not touching converters. After @clairekuang approves requested changes, can be safely merged (blocked atm)