Add filter to skip the modifying when the zone of space is null

specklesystems / speckle-sharp

.NET SDK, Schema and Connectors: Revit, Rhino, Grasshopper, Dynamo, ETABS, AutoCAD, Civil3D & more.

https://speckle.systems

Apache License 2.0

351 stars 162 forks source link

Add filter to skip the modifying when the zone of space is null #3525

Open ItsPatrickHe opened 3 weeks ago

ItsPatrickHe commented 3 weeks ago

"Fix: This PR is made to fix this issue: https://github.com/specklesystems/speckle-sharp/issues/3524
[x] My pull request follows the guidelines in the Contributing guide?
[x] My pull request does not duplicate any other open Pull Requests for the same update/change?
[x] My commits are related to the pull request and do not amend unrelated code or documentation.
[x] My code follows a similar style to existing code.
[x] I have added appropriate tests.
[x] I have updated or added relevant documentation.

ItsPatrickHe commented 3 weeks ago

@RobClaessensRHDHV tag you in the PR :)

ItsPatrickHe commented 1 day ago

@connorivy Could you check this PR? We need this update in order to receive spaces in the project. Thanks in advance.

connorivy commented 1 day ago

Hey @ItsPatrickHe,

Sorry for the delay on this quick fix. I need to familiarize myself with spaces and zones, but are you aware of what the 'CreateRevitZone' method is doing on line 155? It almost looks like that was the intended path for empty speckle zones (but then it's a bit confusing because we then try to assign it's name from the speckle zone)