specklesystems / speckle-sharp

.NET SDK, Schema and Connectors: Revit, Rhino, Grasshopper, Dynamo, ETABS, AutoCAD, Civil3D & more.
https://speckle.systems
Apache License 2.0
370 stars 170 forks source link

D ui3 123 receiving non native attributes revit params gh attributes etc #3526

Closed KatKatKateryna closed 3 months ago

KatKatKateryna commented 3 months ago

UPD: receiving of non-native properties has been turned into a placeholder until we find better strategy for sending props from host apps.

Purpose is to preserve objects properties when placing them into GIS layers(tables). Current approach is to iterate through all objects that will be placed under the same layer and collect their property names and their Type (e.g. string, int) while defaulting to string if nothing better fits). The opinionated choice of non-native properties to receive is:

P.S. atm the following exception is being generated inconsistently, needs better understanding. Thrown during "Conversion" step, so likely not a problem with the current PR: image

image

KatKatKateryna commented 3 months ago

@adamhathcock I tested with the new function, and "default" value doesn't work very well (e.g. it assigns a random date like "{01/01/0001 00:00:00}" ). So I changed it to null and removed a redundant null check from the method calling this one.