DUI3-448 both model card types need 2 clicks to actually cancel 1 to stop operation and 1 to refresh progress bar

specklesystems / speckle-sharp

.NET SDK, Schema and Connectors: Revit, Rhino, Grasshopper, Dynamo, ETABS, AutoCAD, Civil3D & more.

https://speckle.systems

Apache License 2.0

351 stars 162 forks source link

DUI3-448 both model card types need 2 clicks to actually cancel 1 to stop operation and 1 to refresh progress bar #3538

Closed oguzhankoral closed 1 week ago

oguzhankoral commented 1 week ago

It was random probably with some race condition, connectors send sometimes last progress update after cancel and it causes the invalid UI state that seems like progress stuck in UI.

Removed unnecassary dup code in bindings, even function names was wrong.. i.e. OnSendProgressUpdate in Receive binding.
Added cancellation token cancelled? check to prevent progress update for any reason. I believe this is the safest fix for now.