search

specklesystems / speckle-sharp

.NET SDK, Schema and Connectors: Revit, Rhino, Grasshopper, Dynamo, ETABS, AutoCAD, Civil3D & more.
https://speckle.systems
Apache License 2.0
370 stars 170 forks source link

DUI3-326: Add civil3d 2024 converter #3548

Closed clairekuang closed 3 months ago

clairekuang commented 3 months ago

Adds the Civil3d 2024 converter.

This pr includes required changes to container registration in order to support converter injection into a connector vertical. These changes should be reflected in the other DUI3 converter DI projects before this pr is merged.

First pipe sent to speckle from Civil3d: https://app.speckle.systems/projects/b53a53697a/models/719612f9da

Description & motivation

Changes:

To-do before merge:

clairekuang commented 3 months ago

Q: why we removed ITypedConversions and extracted them? In order to use them on Civil3D too?

There is no difference between having a converter implement both ITopLevelConverter and ITypedConverter, or to separate out the typed converter class to be called from the top level converter. I thought the second option is cleaner, so we can see at a glance all our typed converters.