Dui3 177 receive levels in Revit - Githubissues

specklesystems / speckle-sharp

.NET SDK, Schema and Connectors: Revit, Rhino, Grasshopper, Dynamo, ETABS, AutoCAD, Civil3D & more.

https://speckle.systems

Apache License 2.0

351 stars 162 forks source link

Dui3 177 receive levels in Revit #3553

Closed connorivy closed 1 week ago

connorivy commented 1 week ago

Description & motivation

Changes:

RevitRootToHostConverter

A mirror of the RevitRootToSpeckleConverter which not only checks for registered conversions of a specific type, but also moves up the inheritance tree when it doesn't find a converter for the specified type

LevelToHostTopLevelConverter

Moved over the levelToNative method

LevelConversionToSpeckle

This was previously just a 'typedConverter', but I changed this to be a top level converter because not only do we want to converter levels as part of other converters, but we want to send them on their own as well

To-do before merge:

Screenshots:

Validation of changes:

can send and receive levels in Revit

Checklist:

[x] My pull request follows the guidelines in the Contributing guide?
[x] My pull request does not duplicate any other open Pull Requests for the same update/change?
[x] My commits are related to the pull request and do not amend unrelated code or documentation.
[x] My code follows a similar style to existing code.
[ ] I have added appropriate tests.
[ ] I have updated or added relevant documentation.

References