Fix: AppliedAssembly.AdjustedElevation error, and Single Point Featureline error

jhdempsey86 commented 3 months ago

Description & motivation

Fixes #3516

Changes:

If accessing the Civil3D AppliedAssembly.AdjustedElevation property throws an error, then Speckle fails to send the whole corridor. Now defaults to sending double.NaN for this value if this occurs

If a featureline only has one point, then trying to get the spline representation of it would throw an error. Adjust code to check the featureline has more than one point, rather than more than zero.

To-do before merge:

There is no issue with the corridors now being saved in Speckle, and being able to view the corridors in the web viewer. However, the Excel connector and the python connectors seem to

Screenshots:

Validation of changes:

Checklist:

[x] My pull request follows the guidelines in the Contributing guide?
[x] My pull request does not duplicate any other open Pull Requests for the same update/change?
[x] My commits are related to the pull request and do not amend unrelated code or documentation.
[x] My code follows a similar style to existing code.
[x] I have added appropriate tests. - N/A
[x] I have updated or added relevant documentation. - N/A

clairekuang commented 3 months ago

@jhdempsey86 is this in draft for a reason? We're cutting a new 2.20 version today

jhdempsey86 commented 2 months ago

Sorry for the delay, but its now ready, after switchign the data type to a nullable double (double?) Hopefully it can make it into 2.21 release

jhdempsey86 commented 2 months ago

There is currently an issue with the Excel Connector whenever i try and download data from a commit that contains a corridor that has been pushed using the updated code above.

Its unclear what's happening as I can see when I select a commit that some data is downloaded, (im guessing the graphical model) but then the model is never displayed and you see the loading circle indefinitly. I dont think its related to the data or metadata because i am unable to even click the recieve button to even start downloading that data

@clairekuang do you want me to raise a separate bug report on this?

clairekuang commented 2 months ago

@clairekuang do you want me to raise a separate bug report on this?

Is this still the case when changing the adjustedElevation to null instead of double.NaN? A separate issue is preferred if this is a big problem for you, and please include a link to the Speckle commit/version of the corridor you pushed with double.NaN values on that commit, or a link to the civil3d file of the corridor

jhdempsey86 commented 2 months ago

@clairekuang do you want me to raise a separate bug report on this?

Is this still the case when changing the adjustedElevation to null instead of double.NaN? A separate issue is preferred if this is a big problem for you, and please include a link to the Speckle commit/version of the corridor you pushed with double.NaN values on that commit, or a link to the civil3d file of the corridor

Yes, its still an issue even when AdjustElevation is set to null. I will raise a separate bug. Its a big issue for us because we ideally need the Excel tool as part of our workflow (its much easier to get the Guids of objects through excel rather than manually via the viewer)

specklesystems / speckle-sharp