issues
search
specklesystems
/
speckle-sharp
.NET SDK, Schema and Connectors: Revit, Rhino, Grasshopper, Dynamo, ETABS, AutoCAD, Civil3D & more.
https://speckle.systems
Apache License 2.0
372
stars
170
forks
source link
Retry Fixes
#3592
Closed
JR-Morgan
closed
2 months ago
JR-Morgan
commented
2 months ago
Fixed reporting of retries:
We were never incrementing the retry number given to the logger, so it was allways reporting as 0 even if it had retried.
Looks like a regression introduced by
https://github.com/specklesystems/speckle-sharp/pull/2305
when we commented out some logging.
Also fixed the headers which previously were appending new correlation ids with every retry.
Removed ancient flawed retries loop in ServerAPI
Clients already retry with proper backoff policy, this naive loop was only causes problems for the server.