specklesystems / speckle-sharp

.NET SDK, Schema and Connectors: Revit, Rhino, Grasshopper, Dynamo, ETABS, AutoCAD, Civil3D & more.
https://speckle.systems
Apache License 2.0
363 stars 167 forks source link

Civil3D: Extended pset names overriden while receiving data from Speckle #3597

Closed bekraft closed 1 week ago

bekraft commented 1 month ago

Property set names are not handled correctly while sending and receiving data to/from Speckle. They are sent as internal names and replaced by generic Speckle names on load from Speckle.

To achieve a cross tool communication we need stable and correct pset names.

Prerequisites

What package are you referring to?

Civil3D Connector Plugin (tested version 2022)

Describe the bug

To Reproduce

  1. Define a custom extended property set in civil 3d.
  2. Send the object to Speckle.
  3. Receive the object from Speckle.

Expected behavior

Extended property sets are reassembled correcly after receiving data from Speckle. PSet names are taken as key names to properly reference property data from Speckle.

Screenshots

(none)

System Info

Desktop (please complete the following information):

Proposed Solution (if any)

linear[bot] commented 1 month ago

CNX-119 Civil3D: Extended pset names overriden while receiving data from Speckle

clairekuang commented 1 month ago

Partially fixed (name on send) by : https://github.com/specklesystems/speckle-sharp/pull/3598