bjorn/cnx-396-etabs-structure-layout

bjoernsteinhagen commented 2 months ago

Description & motivation

grids not working as desired. Raised multiple times in forum. Problem related mainly to grid rotations when going from ETABS to Speckle.

The issue is not in the GridLineToNative(), but rather in the gridLinesToSpeckle(). Below image shows that the columns between Revit and ETABS remain the same, but the grid changes when sent from ETABS back to Speckle (after being received from Revit).

Changes

In the gridLinesToSpeckle(), we were not aplpying any transformations to the lines according to the rotation. Same logic applied as per GridLineToNative().

See overlaid views below. More details in Testing section below🙌🎉 .

Validation of changes

[x] Case 01 - Revit -> Speckle -> ETABS
[x] Case 02 - ETABS -> Speckle -> ETABS
[x] Case 03 - ETABS -> Speckle -> Revit

Case 01

Case 02

Case 03

Checklist

[x] My pull request follows the guidelines in the Contributing guide?
[x] My pull request does not duplicate any other open Pull Requests for the same update/change?
[x] My commits are related to the pull request and do not amend unrelated code or documentation.
[x] My code follows a similar style to existing code.
[x] I have added appropriate tests.
[ ] I have updated or added relevant documentation.

References

https://speckle.community/t/grasshopper-etabs-problems/8212/3 https://speckle.community/t/etabs-speckle-revit-grid-system-data/11121 https://speckle.community/t/revit-speckle-etabs-mappings-and-levels-and-grids/5430/15

linear[bot] commented 2 months ago

CNX-396 ETABS Structure Layout

gitguardian[bot] commented 2 months ago

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them. Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately. Find here more information about risks.

^{_{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}}

specklesystems / speckle-sharp