RevitConnector: Floors from linked Revit model not converted - Githubissues

specklesystems / speckle-sharp

.NET SDK, Schema and Connectors: Revit, Rhino, Grasshopper, Dynamo, ETABS, AutoCAD, Civil3D & more.

https://speckle.systems

Apache License 2.0

379 stars 173 forks source link

RevitConnector: Floors from linked Revit model not converted #3634

Closed ks-cph closed 1 month ago

ks-cph commented 1 month ago

Prerequisites

[x] I read the contribution guidelines
[x] I checked the documentation and found no answer.
[x] I checked existing issues and found no similar issue.
[x] I checked the community forum for related discussions and found no answer.
[x] I'm reporting the issue to the correct repository (see also speckle-server, speckle-sharp, specklepy, speckle-docs, and others)

What package are you referring to?

Revit converter

Describe the bug

I have a linked model in Revit 2024. When sending, all elements get converted, but the floors fail here in line 187: https://github.com/specklesystems/speckle-sharp/blob/429dcfd6a9bedf1a86f9a44a2c5058ded993f52d/Objects/Converters/ConverterRevit/ConverterRevitShared/PartialClasses/ConvertFloor.cs#L175-L180

It returns null as Doc is not the linked Document where the Floor and Sketch are.

To Reproduce

Link a model with floors, and Send them (I used by selection). All elements will appear but not the floors.

Proposed Solution (if any)

Change from Doc to revitFloor.Document.GetElements.

linear[bot] commented 1 month ago

CNX-594 RevitConnector: Floors from linked Revit model not converted

JR-Morgan commented 1 month ago

Fixed by https://github.com/specklesystems/speckle-sharp/pull/3635