search

specklesystems / speckle-sharp

.NET SDK, Schema and Connectors: Revit, Rhino, Grasshopper, Dynamo, ETABS, AutoCAD, Civil3D & more.
https://speckle.systems
Apache License 2.0
364 stars 168 forks source link

GH: Brep conversion error #478

Closed iltabe closed 3 years ago

iltabe commented 3 years ago

Hi guys.

I have a brep fail conversion happening. It's a consistent error since it happens on all 280 volumes.

image

my master is at this commit 9ddb1fbb061cbabeb5a86109a6be8d193b948691 I attach a ghp with an internalized brep for you to test.

210506_Mule_Bug.zip

AlanRynne commented 3 years ago

Hi @iltabe, we're aware of an issue regarding Rhino brep export that we just fixed yesterday, but isn't yet merged. I'm going to do some final checks and will merge it in. If you wan't to test out the fix, you can pull the latest commit from the alan/brep-fixes branch

https://github.com/specklesystems/speckle-sharp/tree/alan/brep-fixes

iltabe commented 3 years ago

Thanks @AlanRynne I will have a look.

In the meanwhile another problem came up, still with breps. It took me 3h to understand it was speckle! arrghh image The brep is not by both planes. 210506_Mule_Bug02.zip

ps: I didn't have this problem 2 weeks ago, so it must be somthing happend recently.

iltabe commented 3 years ago

I've merged your commit to my master and it looks that at least the boolean difference is now working!

iltabe commented 3 years ago

But the Sender is sending nothing! aaaah

didimitrie commented 3 years ago

I've just given bug_01 a shot:

image

It seems to be working fine! I've tested against several units (meters, feet), and managed to send and receive!

Some possible issues: clean and rebuild the entire solution just in case...

iltabe commented 3 years ago

@didimitrie did you try to send the one that comes out the selected component?

didimitrie commented 3 years ago

Just did - results: image

https://speckle.xyz/streams/e640af6af3/commits/edc9e16ab2

There's some problems (hehe) with the created structure for a reason or another, but i suspect this is due to some unstable changes we discussed with @AlanRynne this morning... (edit: it baked ok too: image )

iltabe commented 3 years ago

Apparently I have a problem to push a single wrapped objects. Sorry If I notch, but I have a deadline...

didimitrie commented 3 years ago

To join the video meeting, click this link: [redacted]

If you have the time, we can debug this quickly!

iltabe commented 3 years ago

Urra! Just delivered the model! :) Thanks guys! @didimitrie I've discovered the object that cause the web viewer to fail: https://speckle.xyz/streams/0355f60d50/objects/4e8f0b403a0e2fa0b6680f552801489a

didimitrie commented 3 years ago

Okay, I've raised a new issue for the viewer: https://github.com/specklesystems/speckle-server/issues/231. Thanks for narrowing it down to the main suspect object! I'll close this one now, as it's been "guerrila" debugged.

Fixes will propagate to releases soon!