GH: Brep conversion from GH to GH fails and falls back to Mesh 😢

specklesystems / speckle-sharp

.NET SDK, Schema and Connectors: Revit, Rhino, Grasshopper, Dynamo, ETABS, AutoCAD, Civil3D & more.

https://speckle.systems

Apache License 2.0

377 stars 172 forks source link

GH: Brep conversion from GH to GH fails and falls back to Mesh 😢 #704

Closed AlanRynne closed 3 years ago

AlanRynne commented 3 years ago

When sending any brep from GH and then getting it back, we get as a result it's mesh representation.

This means that the Brep is failing to be converted. I suspect this may have something to do with the circular references that are set on every brep member to point to it's brep parent.

This is recent, as they work just fine in our latest release.

AlanRynne commented 3 years ago

For future reference, the OnDeserialised method is not being called when deserialising a Brep, so none of it's circular references are being set.

AlanRynne commented 3 years ago

Fixed on @cristi8's Serialisation changes that were just merged in #713