Closed philipbelesky closed 2 years ago
Hey @philipbelesky , thanks for the bug report! We have never tested the unity connector on macOS, so I'm not surprised we have some surprises :) If you wanted to look into this it'd be great, as we're not heavy mac users our resources are limited here.
A quick test you could do is to manually build Core and then copy its DLLs inside the Core folder in the connector.
Otherwise @JR-Morgan might have better ideas!
Thanks for the advice, below are the steps I used to resolve this:
Core
locally; removed all items from Core
folder in speckle-unity and replaced with the core build output
error CS1703: Multiple assemblies with equivalent identity have been imported:
'/Applications/Unity/Hub/Editor/2021.2.8f1/Unity.app/Contents/NetStandard/Extensions/2.0.0/System.Runtime.InteropServices.WindowsRuntime.dll' and '/Users/philip/Sites/speckle-unity/Packages/systems.speckle.speckle-unity/Core/System.Runtime.InteropServices.WindowsRuntime.dll'. Remove one of the duplicate references.
- Deleted the duplicate dll as per error
- Then: same error for `Microsoft.CSharp.dll`; deleted it
- Then:
/Users/philip/Sites/speckle-unity/Packages/systems.speckle.speckle-unity/ConverterUnity.cs(15,41): error CS0535: 'ConverterUnity' does not implement interface member lISpeckleConverter.SetConverterSettings(object)'
- I checked out `all/2.2.4` for the `Core` repo, built it, then repeated the above deletions
- The `Stream Manager` showed the correct parameters and could receive/create data from a Stream
The exact diff for the dependencies [can be seen over here](https://github.com/philipbelesky/speckle-unity/commit/98ed7d914138187440a4bde088221827afa28275). I could make a PR for those but I suspect it isn't of much value and might have Windows regressions.
Having to downgrade the version of `Core` due to that `ConverterUnity.cs` error suggests that a different issue might crop up whenever `Core` is bumped in this repo. Perhaps whenever the `Core` dependencies in this repo are bumped to latest, I could do some more extensive testing across both platforms?
@philipbelesky
Thanks for the investigation, and for the clear steps you took to fix the issue.
The current version of the Unity connector actually uses a 2.2.4 core, so I wonder went wrong when I updated it last 😕. Do please submit a PR in the meantime, as it sounds like you've managed to fix the issue with mac.
I have a few items on the todo list that will require a core bump to 2.3.0, so I'll give updating to 2.3.0 a go when I address those. I'll have a conversation with @teocomi about including mac in our test procedure to make sure unexpected issues like this are less frequent.
This should have been closed a while ago. No issues reported from MacOS users. And was tested several releases ago (2.6), and on the current release (2.9)
Hi! I was following along the documentation and encounter an error when attempting to add the
Stream Manager
to an empty Game Object. This occurs with Unity2020.3.21f1
or2021.2.8f1
running on macOS. After the error appears, theStream Manager
attaches to the object but does not have any fields.Hopefully this isn't anything specific to my machine. I also wasn't sure if macOS was supported.
If helpful, I could attempt a PR for this although would need some pointers - my experience with .NET dependency management is pretty limited.