Dash v20 hardfork support

spesmilo / electrumx

Alternative implementation of spesmilo/electrum-server

MIT License

429 stars 343 forks source link

Dash v20 hardfork support #234

Closed sapph1re closed 6 months ago

sapph1re commented 9 months ago

Coinbase transactions with new fields are now supported and ElectrumX now synchronizes well.

Also removed legacy SubTx transactions.

pshenmic commented 8 months ago

The changes was tested against Dash Testnet v20 (dashpay/dashd:20.0.0-beta.4) and production server deployed at the

dash-electrum-testnet.pshenmic.dev:50002

Changes can be tested by anyone via latest dash electrum client (https://github.com/Bertrand256/electrum-dash)

UdjinM6 commented 6 months ago

v20 just activated on mainnet at block 1987776 and I can confirm that this code seems to be working correctly

SomberNight commented 6 months ago

The tests are failing (on the CI). Potentially a simple rebase might be enough.

UdjinM6 commented 6 months ago

@sapph1re could you pls try rebasing it and see if it helps?

cipig commented 6 months ago

i can confirm that the code works updated our DASH electrums (https://1209k.com/bitcoin-eye/ele.php?chain=dash, the cipig.net ones) with this and they are back online after they initially crashed on HF activation

UdjinM6 commented 6 months ago

Confirmed that rebasing fixes CI https://github.com/spesmilo/electrumx/pull/242

SomberNight commented 6 months ago

thanks