-sdvxnosub not working for some systems - Githubissues

spice2x / spice2x.github.io

🌶️ spice2x is a spicier fork of SpiceTools with hundreds of bug fixes and new features 🌶️

https://spice2x.github.io/

GNU General Public License v3.0

108 stars 2 forks source link

-sdvxnosub not working for some systems #180

Open Yaellus opened 3 months ago

Yaellus commented 3 months ago

When launching SDVX the sub screen automatically opens on my second screen, hiding anything that was previously under it. Since I only use the subscreen with the in-game overlay it would be nice if this screen would be able to launch minimized so I don't have to alt-tab after launching the game to manually minimize it.

sp2xdev commented 3 months ago

Are you using full screen or windowed mode?

If full screen, you can use SDVX Subscreen Disable (-sdvxnosub).

Yaellus commented 3 months ago

I am on fullscreen. For some reason if I enable -sdvxnosub it still pops up for some reason. My second monitor is also in portrait mode, might cause some funky behaviour.

sp2xdev commented 3 months ago

I'm not seeing issues with this on my PC with two monitors set to portrait - if you can provide the log.txt file and maybe your GPU model it might help.

Yaellus commented 3 months ago

I have a 3080 in my system

sp2xdev commented 3 months ago

This part is present which means spice is at least trying:

[2024/06/16 22:08:52] I:graphics::d3d9: disabling adapter group device with force single adapter mode

not sure what the issue is, might be some race condition in voltex DLL.

sp2xdev commented 3 months ago

If you have any tools like RivaTuner / MSI After burner etc, it would be the first thing I suspect.

Yaellus commented 3 months ago

I do have MSI afterburner running usually, turning it off doesn't change anything though. Still launches with the subscreen on my second monitor

sp2xdev commented 3 months ago

As an alternative you should be able to use "disable subscreen" patch for the DLL.

sp2xdev commented 3 months ago

Some notes during investigation:

Seems that on some configurations, the game does not respect D3DCREATE_ADAPTERGROUP_DEVICE being clear. On systems it does work, even though the same DLL is being used. Unsure what the difference is.
The game primarily relies on NumberOfAdaptersInGroup value returned by GetDeviceCaps to determine is subscreen should be rendered. You'll see a log entry like this: [2024/06/19 17:12:20] I:InitD3D: NumberOfAdaptersInGroup=2 if this is 1, the game will gracefully fail (with a message saying the system doesn't support multi-head), and causes the subscreen window to not launch. While this may solve the problem OP reported, it also causes the subscreen window to be not created at all, which means subscreen overlay won't work... so this is only a half solution.
The hex edit is more reliable here, as it directly modifies what the game DLL does with adapter number. It's possible that we'll just have to live with the hex edit unless we come up with some clever way in spice to shim things via hooks.

Yaellus commented 3 months ago

while the hex edit does stop the second screen from opening on my second monitor, this also removes it from the spice overlay, which I don't want

sp2xdev commented 3 months ago

That is unfortunate. I think the angle we should take on moving forward is: what is different about these PCs that continue to show the second screen when the option is enabled? That way, we might be able to figure out how to convince the DLL to stop doing that. Maybe worth trying to see if an older DLL still has the same issue, or if it's new in new DLLs.