[Patch] Enable StepManiaX cabinet lighting via a forked StepManiaX SDK. Load SMX.dll at runtime, instead of including the stepmaniax-sdk source directly.

[skogaby]

[!NOTE] Before submitting code changes...

• Please do note that this is a GPL v3.0 open source project.
• Please read the CONTRIBUTING guide.
• Maintainers reserve the right to reject or modify your submission without reason.
• If accepted, your github user name will be credited on the main web page, and then archived in the past versions wiki page

Feel free to remove this section after you have read it.

Description of change

This change does a couple of things:

• Add support for StepManiaX Dedicated Cabinet lights support. This is accomplished through a custom fork of the StepManiaX SDK which adds a new API meant for controlling cabinet lights.
  • I'm attempting now to have this API upstreamed into the mainline stepmaniax-sdk repo.
• Remove the stepmaniax-sdk source code from the Spice2x repo, and instead load SMX.dll at runtime. This is to minimize the amount of maintenance needed for bringing in new SMX SDK versions, since the existing version had hardcoded changes that aren't upstreamed, to make the SMX SDK compile outside of MSVC.
• Since we load the SMX.dll at runtime now, only the original, base APIs for stage lighting are actually required. If a SMX.dll is loaded that does not support cabinet lighting, the calls are essentially no-ops.

Compiling

• Compiled using the included build_docker.sh

Testing

• Tested on a StepManiaX Dedicated Cabinet
• Verified I can use just a cabinet device, just stage devices, or a combination thereof without issue
• Verified I can load the stock SMX.dll which does not include cabinet lighting changes, and nothing breaks

Patch file

• Git patch is included

skogaby_smx_patch_20241010.patch

[sp2xdev]

Merged, thanks for the contribution. I do like having the DLL loaded at runtime instead of static linking.

I have no way to test this so I'll just take your word for it.

Where is the fork for the DLL? Seems like SMX team does not distribute a binary, so it would be nice to provide one somewhere for users.

[skogaby]

https://github.com/skogaby/stepmaniax-sdk/releases

Here's a release with 32-bit and 64-bit DLLs of my current code. If I make any changes before getting it upstreamed, I'll continue posting them here.