spinal-cord-7t / coil-qc-code

7T Spinal Cord Coil QC Analysis Code
https://spinal-cord-7t.github.io/coil-qc-code/README.html
1 stars 1 forks source link

Coil design from MSSN is inaccurate #113

Open jcohenadad opened 1 month ago

jcohenadad commented 1 month ago

The current coil design (made by NeuroPoly on SolidWorks, based the paper), is apparently inaccurate, according to comments from Alan Seifert on the ISMRM abstract gdoc:

the coil elements in the MSSM coil appear a bit too high in this illustration, especially the anterior ones. The most inferior row of each panel appears in just about the right location, but the arrays extend too far superiorly. Could you check it again against Figure 1 in 10.1002/mrm.26538?

Here is the current version:

image

And here is the suggestion for how to modify it (approximate manual indications on draw).

Once the suggestion is made, we will modify the design on SolidWorks to re-generate the figure.

jcohenadad commented 1 month ago

@alanseifert how about this?

Screenshot 2024-10-31 at 3 23 40 PM

I know you wanted the anterior elements to be lower, but that would require half a day of work and as you can imagine this is a very busy time of the year, so let us know if that could pass for the ISMRM abstract. We can update later.

With the PDF: MSSM figure 2024-10-31.pdf

alanseifert commented 1 month ago

This new version is actually less accurate than the old one. The anterior panel elements are contoured on the surface of two cylinders (not one): a large cylinder around the head, and a smaller cylinder around the neck, with a disk as a transition to step the radius down from the head to the neck.

If it takes that long to adjust the position of the elements, then I completely understand and agree that it's not a productive use of time. We should revert to the first version of this figure and not use this revised version.

On Thu, Oct 31, 2024 at 3:25 PM Julien Cohen-Adad @.***> wrote:

@alanseifert https://github.com/alanseifert how about this?

Screenshot.2024-10-31.at.3.23.40.PM.png (view on web) https://github.com/user-attachments/assets/e92c4397-072b-49a1-882d-237aa8c6591e

I know you wanted the anterior elements to be lower, but that would require half a day of work and as you can imagine this is a very busy time of the year, so let us know if that could pass for the ISMRM abstract. We can update later.

— Reply to this email directly, view it on GitHub https://github.com/spinal-cord-7t/coil-qc-code/issues/113#issuecomment-2450658352, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH77D2C6W63BKPJON6H4HCTZ6J727AVCNFSM6AAAAABQTPQKG2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJQGY2TQMZVGI . You are receiving this because you were mentioned.Message ID: @.***>

jcohenadad commented 1 month ago

Gotcha! It is very difficult to appreciate the actual 3D representation of the coil based on a 2D picture only. It would be very helpful if you could provide further measurements. Eg I made this quick sketch below-- if you could confirm this is OK, and also provide the x,y,z measures that would be great.

image

alanseifert commented 1 month ago

The transition between the two cylinders on the anterior panel is two right angles, and z = 0. Here's a sketch. Only the posterior panel has smooth transitions.

But again, if it's too inefficient a use of time, the original version is ok.

On Fri, Nov 1, 2024 at 9:09 AM Julien Cohen-Adad @.***> wrote:

Gotcha! It is very difficult to appreciate the actual 3D representation of the coil based on a 2D picture only. It would be very helpful if you could provide further measurements. Eg I made this quick sketch below-- if you could confirm this is OK, and also provide the x,y,z measures that would be great.

image.png (view on web) https://github.com/user-attachments/assets/35b93c41-7dbf-4e46-9ae4-7dceb6153737

— Reply to this email directly, view it on GitHub https://github.com/spinal-cord-7t/coil-qc-code/issues/113#issuecomment-2451846293, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH77D2HXH2YU7A5W4NX3CRLZ6N4RVAVCNFSM6AAAAABQTPQKG2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJRHA2DMMRZGM . You are receiving this because you were mentioned.Message ID: @.***>

jcohenadad commented 1 month ago

@alanseifert you probably answered that comment via email (instead of within GitHub), hence I don't see your sketch. Would you mind drag/dropping it on the post? Or if too cumbersome just email it to me and l'll add it here. Thank you!

alanseifert commented 1 month ago

Photo Nov 01 2024, 12 36 29 PM

honzink commented 3 weeks ago

Is this better?

MSSM figure 2024-11-05

@alanseifert

jcohenadad commented 3 weeks ago

@honzink I suspect, based on the sketch from Alan, that the elements in the bottom row are not curved along the AP direction, but it is only the lower Tx/Rx (purple) element that is at the junction between the small and the big cylinder, and that is therefore warped to follow the discontinuity.

alanseifert commented 3 weeks ago
Screenshot 2024-11-05 at 4 29 14 PM

Photo Nov 01 2024, 12 36 29 PM Photo Nov 01 2024, 12 36 29 PM

This newest version is better in that it follows the two cylinders exactly, but worse in terms of the sizes and shapes of the lowest row, and still inaccurate in terms of the locations of all elements. The original diagram in the first draft of the abstract is still, on balance, the best.

honzink commented 2 weeks ago

@alanseifert thank you for your input. It is difficult for me to reproduce the coil from the figure paper. Do you mind going step by step? Starting with the coil former you mentioned above for the anterior elements. I assume the cylinders are concentric? Does this look ok to you? Or do I need to move the cylinders? Units are in mm. anterior coil former dim

alanseifert commented 2 weeks ago

Would it help if I send the STL files?

On Tue, Nov 12, 2024 at 10:37 AM Jan Paska @.***> wrote:

@alanseifert https://github.com/alanseifert thank you for your input. It is difficult for me to reproduce the coil from the figure paper. Do you mind going step by step? Starting with the coil former you mentioned above for the anterior elements. I assume the cylinders are concentric? Does this look ok to you? Or do I need to move the cylinders? Units are in mm. anterior.coil.former.dim.jpg (view on web) https://github.com/user-attachments/assets/ff439900-d839-4aa4-8715-4c2b421efaca

— Reply to this email directly, view it on GitHub https://github.com/spinal-cord-7t/coil-qc-code/issues/113#issuecomment-2470861901, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH77D2GHI5IGV244NAJVXYL2AIOCLAVCNFSM6AAAAABQTPQKG2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINZQHA3DCOJQGE . You are receiving this because you were mentioned.Message ID: @.***>

honzink commented 2 weeks ago

Yes, that would be great. My email is: jan.paska@polymtl.ca