spinal-cord-7t / coil-qc-code

7T Spinal Cord Coil QC Analysis Code
0 stars 0 forks source link

Subject ID should be coherently referred to across the dataset #31

Closed jcohenadad closed 5 months ago

jcohenadad commented 5 months ago

Currently, our list mixes center name (eg: MGH, NYU) and city (eg: Marseille).

We should use a single convention.

My suggestion, given that Marseille is the only 'outlier', would be to use center name. In this case, we should replace Marseille by CRMBM

Kyota-exe commented 5 months ago

According to this comment from #13, we would also have to replace NYU by MtSinai.

jcohenadad commented 5 months ago

According to https://github.com/spinal-cord-7t/coil-qc-code/issues/13#issuecomment-1952850690, we would also have to replace NYU by MtSinai.

Correct. And to be consistent with the use of acronym, we could also consider calling the dataset MSSM (Mount Sinai School of Medicine, which seems to be an official acronym from the website: https://icahn.mssm.edu/). Would that be acceptable to you @alanseifert ?

alanseifert commented 5 months ago

Yes, MSSM would be best.

On Mon, Apr 15, 2024 at 11:41 AM Julien Cohen-Adad @.***> wrote:

According to #13 (comment) https://github.com/spinal-cord-7t/coil-qc-code/issues/13#issuecomment-1952850690, we would also have to replace NYU by MtSinai.

Correct. And to be consistent with the use of acronym, we could also consider calling the dataset MSSM (Mount Sinai School of Medicine). Would that be acceptable to you @alanseifert https://github.com/alanseifert ?

— Reply to this email directly, view it on GitHub https://github.com/spinal-cord-7t/coil-qc-code/issues/31#issuecomment-2057163443, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH77D2HNUH2GRPEJVVIRB4TY5PYJDAVCNFSM6AAAAABGGKGQWCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJXGE3DGNBUGM . You are receiving this because you were mentioned.Message ID: @.***>

Kyota-exe commented 5 months ago

I created a new version, v2.1.0, on OpenNeuro, implementing the following changes: NYU -> MSSM Marseille -> CRMBM

This issue should thus now be solved.

jcohenadad commented 5 months ago

Nice job @Kyota-exe 👏