spinal-cord-7t / coil-qc-code

7T Spinal Cord Coil QC Analysis Code
0 stars 0 forks source link

Remove `dataset_description.json` #44

Closed jcohenadad closed 2 months ago

jcohenadad commented 2 months ago

It is already present on OpenNeuro

Kyota-exe commented 2 months ago

I had it there because my script bids_conversion.py used to copy the dataset_description.json from this directory to the output directory, which I upload to OpenNeuro whenever I want to update the dataset. So it isn't a duplicate; it's the source of the dataset_description.json which is on OpenNeuro.

Now, after a recent commit e1ead19, instead of copying dataset_description.json, it copies dataset_description-human.json and dataset_description-phantom.json (https://github.com/spinal-cord-7t/coil-qc-code/blob/main/bids_conversion.py#L187) to the output directories for the human dataset and the phantom dataset respectively. I had forgotten to commit these files and remove dataset_description.json.

I propose to remove dataset_description.json because it is no longer being used in any context, but to commit dataset_description-human.json and dataset_description-phantom.json which I have locally, since bids_conversion.py uses them, even if they are already on OpenNeuro (as the dataset_description.jsons of the 2 datasets). This will allow us to easily change them if ever needed.

Kyota-exe commented 2 months ago

This should be resolved by 2f8a6d8.