spinal-cord-7t / coil-qc-code

7T Spinal Cord Coil QC Analysis Code
0 stars 0 forks source link

Confusing code for labeling, mask creation and registration #84

Closed jcohenadad closed 1 week ago

jcohenadad commented 1 week ago

The purpose of the loop is unclear-- it says 'label creation' but the loop includes registration code

https://github.com/spinal-cord-7t/coil-qc-code/blob/e6ac4b386a33ded3614fb6ccff742dd97e1c7330/data_processing-phantom.ipynb#L353-L364

jcohenadad commented 1 week ago

I'll also re-work the logic of variable names for the masks, to be consistent with the rest of the code.